VoyageAIRerank constructor fix #17343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
.../llama-index-postprocessor-voyageai-rerank/llama_index/postprocessor/voyageai_rerank/base.py
Show resolved
Hide resolved
|
@logan-markewich Terribly sorry for the ping. I just saw you approved another PR a couple hours back, wanted to make sure this PR doesn't go stale. |
logan-markewich
approved these changes
Dec 29, 2024
|
No worries @Adversarian -- its holiday break so reviewing PRs has been a little lax lol |
|
Ah, I understand. I forgot it's that time of year now. Happy new year and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the new
voyageaiclient, thererankmethod does not taketruncationas an optional nullable argument. Furthermore,top_nis an optional nullable argument but was defined as a non-optional non-nullable argument previously. This made it so that the construction of the class without all the unrequired arguments would result in a validation error from Pydantic.This change shouldn't be breaking for all intents and purposes since default values have been supplied where necessary and they will be overridden if otherwise specified. A unit test was developed for this specific case.
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.